Vai al contenuto

Discussioni utente:Jon (WMF)

Contenuti della pagina non supportati in altre lingue.
Aggiungi argomento
Da Wikivoyage.
Ultimo commento: 1 mese fa, lasciato da Jdlrobson in merito all'argomento Minor bug on Listing Editor

Benvenuto

[modifica]
Ciao Jon (WMF)!

Benvenuta/o su Wikivoyage in lingua italiana! Stiamo realizzando un'attendibile guida turistica mondiale libera e aggiornabile. Aiutaci anche tu! Se hai appena conosciuto Wikivoyage e non sai come funziona e in che modo puoi aiutarci, poni le tue domande nella Lounge, il punto d'incontro dei wikiviaggiatori, oppure consulta le nostre pagine di aiuto.

Potrai trovare risposte ai tuoi dubbi anche nelle pagine delle domande frequenti e dei consigli per i nuovi arrivati.

Ricordati soprattutto che è vietato copiare testi protetti da copyright. Il nostro obiettivo non è proporre contenuti copiati da altri siti, ma scrivere una nuova guida turistica di nostro pugno.


--Andyrom75 (discussioni) 07:11, 19 mag 2020 (CEST)Rispondi

Minor bug on Listing Editor

[modifica]

Hi @Jdlrobson, I've noticed a minor bug in Eminönü#İDO Eminönü Terminali element.

If you open this element on listing editor, you'll see the correct "go"-type, but if you open the type menu, you'll see 2 "go"s. This thing doesn't happen on en:voy.

Could you take a look at it? Andyrom75 (discussioni) 16:27, 9 dic 2025 (CET)Rispondi

Could you address the bug in the JavaScript console?:
ext.gadget.ListingEditor2023-script-0.js:153 Please define config.sectionType in [[MediaWikiGadget-ListingEditor.json]].
Failure to do this will break future versions of the listing editor.
See https://en.wikivoyage.org/w/index.php?title=MediaWiki%3AGadget-ListingEditor.json for reference. that might be related.
I've filed https://github.com/jdlrobson/Gadget-Workshop/issues/27 in case that doesn't work to follow up. Thanks for the report! Jdlrobson (discussioni) 17:20, 9 dic 2025 (CET)Rispondi
@Jdlrobson I remember that I didn't put "go" type in the json because we don't have a template called "go". Only now I understand that go shall be there in any case because it's managed through type=go. Thanks for the hint.
I've applied the patch. Currently nothing happened but maybe it's just a cache issue. I'll check later. Andyrom75 (discussioni) 19:33, 9 dic 2025 (CET)Rispondi
You need to update sectionType too.
:::	"sectionType": {
:::        "Cosa_vedere": "see",
:::        "Cosa_fare": "do",
:::        "Acquisti": "buy",
:::        "Dove_mangiare": "eat",
:::        "Come_divertirsi": "drink",
:::        "Dove_alloggiare": "sleep",
:::        "Eventi_e_feste": "listing",
:::        "Come arrivare": "listing",
:::        "Come spostarsi": "listing"
:::	},
:::
Jdlrobson (discussioni) 20:27, 9 dic 2025 (CET)Rispondi
@Jdlrobson, mmm, what's the purpose? Do I really have to list all the possible sections or just the most commons? Andyrom75 (discussioni) 20:45, 9 dic 2025 (CET)Rispondi
Forget the question. I got the point :-P
Now I should have completely updated the json, but I still see the two "go"s. Andyrom75 (discussioni) 20:50, 9 dic 2025 (CET)Rispondi
@Jdlrobson, after one day I still see the two "go"s, at this point I exclude a cache issue. Andyrom75 (discussioni) 09:52, 10 dic 2025 (CET)Rispondi
I debugged this last night. https://it.wikivoyage.org/wiki/MediaWiki:Gadget-ListingEditor.json has 'go' LISTING_TEMPLATES_OMIT. We don't seem to support removal of default templates currently. Before I did that I want to understand if the addition in LISTING_TEMPLATES_OMIT is intentional? Jdlrobson (discussioni) 17:05, 10 dic 2025 (CET)Rispondi
@Jdlrobson, as said, we don't have a template go, this is not part of the "listing core group", this is a custom listing widely spread in en:voy.
So now the point is: how to treat it? And, how to treat any other custom listing template?
I mean, we can also implement it, but we should contemplate the case that this wiki, or another wiki, will keep the original set of listing templates. Andyrom75 (discussioni) 19:00, 10 dic 2025 (CET)Rispondi
so is the expectation that since this is a custom template the "go" option should not appear in the listing editor except in the case of this example (where it being used)? Jdlrobson (discussioni) 21:45, 10 dic 2025 (CET)Rispondi
In my opinion the two viable options are the following:
1) (the one you propose) to treat "go" as any other custom listing
2) since "go" is widely spread on en:voy, you can keep it in the menu of the listing editor, but comparing the listing type with the menu list. You'll add the listing type only if it's not in the listing menu.
This second approach, would incentivate the use of the "go" listing (in this case) in the other wikis, but would allow them to not implement it if they don't want.
What do you think? Andyrom75 (discussioni) 10:58, 11 dic 2025 (CET)Rispondi
@Jdlrobson ping :-) Andyrom75 (discussioni) 10:59, 11 dic 2025 (CET)Rispondi
@Jdlrobson, which is the approach that you decided to take? Andyrom75 (discussioni) 08:31, 16 dic 2025 (CET)Rispondi
@Jdlrobson, I'll be on vacation on the following weeks, but I hope you can find the time to solve this bug before I'll come back, and most important: before I'll forget it :-P :-D
Thanks and merry Xmas. Andyrom75 (discussioni) 08:46, 25 dic 2025 (CET)Rispondi
@Jdlrobson, I've noticed that you made a major change but unfortunately the editor doesn't work anymore. Could you check? Andyrom75 (discussioni) 13:42, 15 gen 2026 (CET)Rispondi
@Jdlrobson, now it seems that all works correctly. I have some feedback for your evaluation.
  1. Since the body of the window it's the core part, would it be possible to shrink either the header and the footer to give more space to the body? I would also reduce the height of the of the edit/preview bar.
  2. the "(È è é )" should be positioned only on the left the description field, not also on top for the same reason. Furthermore, as you can see, there is an extra space that should be removed.
  3. after the clicking the save button, the "? Salva Annulla" buttons are still visible on the saving window, but those buttons should be removed.
  4. The saving window disappear before the saving is completed infact I can't open another listing editor immediately and this is weird. After a while, the page refresh and only at that point I can open another listing editor. Maybe you should hook an event.
I hope this feedback can help you to further improve the tool. You made a great job! Andyrom75 (discussioni) 10:24, 17 gen 2026 (CET)Rispondi
Let's continue the discussion on my volunteer talk page. I don't monitor this account's talk page as much. Jdlrobson (discussioni) 18:37, 17 gen 2026 (CET)Rispondi